[MPlayer-cvslog] [propchange]: r25135 - svn:log

[Diego Biurrun]

On Thu, Nov 22, 2007 at 03:53:40PM +0200, Ivan Kalvachev wrote:
> 2007/11/22, Diego Biurrun <diego at biurrun.de>:
> > On Thu, Nov 22, 2007 at 02:59:33PM +0200, Ivan Kalvachev wrote:
> > > 2007/11/22, diego <subversion at mplayerhq.hu>:
> > > >
> > > > Property diff:
> > > > --- old property value
> > > > +++ new property value
> > > > @@ -1,3 +1,4 @@
> > > >  Fix compilation error.
> > > > -FFmpeg commit r11071 removed the static ByteIOContext from AVFormatContext and replaced it with dynamic.
> > > > -However muxer_lavf.c haven't been modified to reflect that change.
> > > > +FFmpeg commit r11071 removed the static ByteIOContext from AVFormatContext
> > > > +and replaced it with a dynamic one.
> > > > +However muxer_lavf.c had not been modified to reflect that change.
> > >
> > > Do not break single line on multiple lines.
> > >
> > > Do not fix my commit messages!
> > >
> > > NEVER!!
> >
> > Commit messages are an integral part of the code's documentation.  They
> > should be explanatory and not confusing.  Grammar mistakes and
> > suboptimal formatting reduce commit message quality.
> >
> > I will take the necessary steps to keep commit message quality high.  If
> > you misinterpret this as anything but the favor and service to you that
> > it is, well, it's not my problem.  However, flaming and commit wars are
> > silly and counterproductive, please refrain from it.
> 
> Please never commit changes in my stuff without my approval.
> This includes my commit messages.
> 
> If you want something fixed, tell me.

I will not be bothered to send patches for grammar fixes.  My changes
arrive at the mailing list for everyone to review.  If you dislike this,
have somebody review your commit messages beforehand on IRC.  With your
number of commits, this should not be a problem.

> Do not abuse your position.

I am not abusing "my" position.

Diego