[MPlayer-cvslog] r25031 - trunk/libmpcodecs/vf_2xsai.c

Michael Niedermayer michaelni at gmx.at
Tue Nov 13 03:52:00 CET 2007


Hi

On Mon, Nov 12, 2007 at 09:40:13PM +0100, reimar wrote:
> Author: reimar
> Date: Mon Nov 12 21:40:13 2007
> New Revision: 25031
> 
> Log:
> Use proper inttypes.h types instead of broken uint32 etc. defines
[...]
> -static uint32 colorMask = 0xF7DEF7DE;
> -static uint32 lowPixelMask = 0x08210821;
> -static uint32 qcolorMask = 0xE79CE79C;
> -static uint32 qlowpixelMask = 0x18631863;
> -static uint32 redblueMask = 0xF81F;
> -static uint32 greenMask = 0x7E0;
> +static uint32_t colorMask = 0xF7DEF7DE;
> +static uint32_t lowPixelMask = 0x08210821;
> +static uint32_t qcolorMask = 0xE79CE79C;
> +static uint32_t qlowpixelMask = 0x18631863;
> +static uint32_t redblueMask = 0xF81F;
> +static uint32_t greenMask = 0x7E0;
>  static int PixelsPerMask = 2;

you could have vertically aligned them like:
static uint32_t     colorMask = 0xF7DEF7DE;
static uint32_t  lowPixelMask = 0x08210821;
static uint32_t    qcolorMask = 0xE79CE79C;
static uint32_t qlowpixelMask = 0x18631863;
static uint32_t   redblueMask = 0x0000F81F;
static uint32_t     greenMask = 0x000007E0;


/me wonders how much i can nitpick before ill get flamed ;)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20071113/e91fb998/attachment.pgp>


More information about the MPlayer-cvslog mailing list