[MPlayer-cvslog] r24941 - trunk/mplayer.c

[Diego Biurrun]

On Fri, Nov 09, 2007 at 01:01:07PM +0200, Uoti Urpala wrote:
> On Fri, 2007-11-09 at 00:58 +0100, Diego Biurrun wrote:
> > Great, so can we please form a non-aggression pact at this point?
> > 
> > Obviously nobody can stop you from mixing declarations and statements,
> > but could you please refrain from flaming the people that clean up after
> > you?
> 
> I think someone insisting to have his way by changing all code written
> by another is not a sustainable long-term situation. It is also quite
> far from what I'd call "non-aggression". If both sides in a disagreement
> behaved equally "non-aggressively" it would lead to a commit war.
> 
> If you claim you want to avoid flaming I think you could choose better
> words than calling such activity "cleaning up after you".

True, that choice of words is less than perfect.  Let me rephrase it in
more neutral terms:

Obviously nobody can stop you from mixing declarations and statements,
but can you live with people making changes after you?

> >   I'll have them refrain from making snide remarks in the commit
> > messages in return.
> 
> Snide remarks are something I can ignore myself if needed.
 
Fine.

> > > Especially when the most often cited "rules" seem to come from old
> > > development practices that were already seen not to work and turned
> > > the code into a mess.
> > 
> > Which rules lead to a mess and why please?
> 
> I think it is clear that the "traditional" MPlayer development practices
> did lead to a mess. I think the biggest single factors were the aversion
> to any "cosmetic" changes at all and the strict code ownership policy.

The refusal of any kind of cosmetic changes is a thing of the past.  I
completely agree that it was stupid and counterproductive.

Could you elaborate on the code ownership policy?  I don't see us having
such a thing now.

Diego