[MPlayer-cvslog] r24966 - trunk/libvo/vo_directfb2.c

[Carl Eugen Hoyos]

Hi!

Reimar Döffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:

> > --- trunk/libvo/vo_directfb2.c	(original)
> > +++ trunk/libvo/vo_directfb2.c	Sun Nov  4 14:41:07 2007
> > @@ -1186,8 +1186,8 @@ static uint32_t get_image(mp_image_t *mp
> >         if (!frame) {
> >              if(mpi->flags&MP_IMGFLAG_PLANAR){
> >  		mpi->planes[0]= dst + yoffset * pitch + xoffset;
> > -		mpi->planes[1]+= ((yoffset * pitch) >> 2) + (xoffset >> 1);
> > -		mpi->planes[2]+= ((yoffset * pitch) >> 2) + (xoffset >> 1);
> > +		mpi->planes[1]+= (yoffset * pitch) >> (2 + xoffset) >> 1;
> > +		mpi->planes[2]+= (yoffset * pitch) >> (2 + xoffset) >> 1;
> 
> Uh... No idea what the previous commit was, and maybe this really
> restores the same behaviour as originally, but I can't imagine this is
> correct...

I had a similar feeling yesterday, so I tried to test.
The problem is: Every version I tried (pre7(?), rc1, rc2, yesterday, today)
shows wrong colours at a wrong resolution, and no visible changes since
yesterday;-(

Does it work for anybody on Linux?

Carl Eugen