[MPlayer-cvslog] r24966 - trunk/libvo/vo_directfb2.c

[Balatoni Denes]

Hi!

Sunday 04 November 2007 14:41-kor diego ezt írta:
> Author: diego
> Date: Sun Nov  4 14:41:07 2007
> New Revision: 24966
>
> Log:
> Fix previous incorrect commit, +/- has higher precedence than shifts.
>
>
> Modified:
>    trunk/libvo/vo_directfb2.c
>
> Modified: trunk/libvo/vo_directfb2.c
> ===========================================================================
>=== --- trunk/libvo/vo_directfb2.c	(original)
> +++ trunk/libvo/vo_directfb2.c	Sun Nov  4 14:41:07 2007
> @@ -1186,8 +1186,8 @@ static uint32_t get_image(mp_image_t *mp
>         if (!frame) {
>              if(mpi->flags&MP_IMGFLAG_PLANAR){
>  		mpi->planes[0]= dst + yoffset * pitch + xoffset;
> -		mpi->planes[1]+= ((yoffset * pitch) >> 2) + (xoffset >> 1);
> -		mpi->planes[2]+= ((yoffset * pitch) >> 2) + (xoffset >> 1);
> +		mpi->planes[1]+= (yoffset * pitch) >> (2 + xoffset) >> 1;
> +		mpi->planes[2]+= (yoffset * pitch) >> (2 + xoffset) >> 1;
>  	    } else {
>  		mpi->planes[0]=dst + yoffset * pitch + xoffset * (mpi->bpp >> 3);
>  	    }

Although it's the correct warning fix, IMHO the code looks broken from the 
start.

bye
Denes