[MPlayer-cvslog] r23246 - in trunk: cfg-mplayer.h libmenu/menu.c

[Reimar Döffinger]

Hello,
On Mon, May 07, 2007 at 05:59:54PM +0200, ben wrote:
> +      buffer_size = 1024 > (len+1) ? 1024 : (len+1);

FFMAX?

> +      logical = (FriBidiChar*) malloc(buffer_size);
> +      visual = (FriBidiChar*) malloc(buffer_size);
> +      outputstr = (char*) malloc(buffer_size);
> +    } else if (len+1 > buffer_size) {
> +      buffer_size = len+1;
> +      logical = (FriBidiChar*) realloc(logical, buffer_size);
> +      visual = (FriBidiChar*) realloc(visual, buffer_size);
> +      outputstr = (char*) realloc(outputstr, buffer_size);

Please do not uselessly cast void *.

Greetings,
Reimar Döffinger