[MPlayer-cvslog] r22815 - trunk/configure

[Rich Felker]

On Sat, Mar 24, 2007 at 09:16:34PM +0100, diego wrote:
> Author: diego
> Date: Sat Mar 24 21:16:34 2007
> New Revision: 22815
> 
> Modified:
>    trunk/configure
> 
> Log:
> Unconditionally add -li386 to LDFLAGS on OpenBSD.
> 
> 
> Modified: trunk/configure
> ==============================================================================
> --- trunk/configure	(original)
> +++ trunk/configure	Sat Mar 24 21:16:34 2007
> @@ -6033,7 +6033,6 @@ if test "$_win32dll" = yes ; then
>    _def_win32dll='#define USE_WIN32DLL 1'
>    test -z "$_win32codecsdir" && _win32codecsdir=$_codecsdir
>    _res_comment="using $_win32codecsdir"
> -  openbsd && x86_32 && _ld_extra="$_ld_extra -li386"
>    if not win32 ; then
>      _def_win32_loader='#define WIN32_LOADER 1'
>    else
> @@ -7230,6 +7229,7 @@ fi
>  _ld_extra="$_ld_extra $_ld_pthread $_ld_dl $_ld_dl_dynamic"
>  bsdos && _ld_extra="$_ld_extra -ldvd"
>  netbsd && x86_32 && _ld_extra="$_ld_extra -li386"
> +openbsd && x86_32 && _ld_extra="$_ld_extra -li386"

I'm generally against the practice of assuming that special hacks are
needed based completely on the name of the OS. If you want to know
why, try egrep ^#.{40} in the source directory to GNU screen and see
where it leads.

It would be much better to do a test to see if -li386 works when on
obsd, and if not, either omit it or disable the features that might
depend on it. But everything should be driven by tests, not by
assuming that OS 'foo' has requirements 'bar' and 'blah'.

Rich