[MPlayer-cvslog] r22797 - trunk/libdha/Makefile

[Diego Biurrun]

On Sat, Mar 24, 2007 at 06:53:46PM +0100, Diego Biurrun wrote:
> On Sat, Mar 24, 2007 at 07:31:27PM +0200, Ivan Kalvachev wrote:
> > 2007/3/24, diego <subversion at mplayerhq.hu>:
> > >
> > >Log:
> > >Remove OpenBSD linking hack.  If this is (still) necessary, it needs to be
> > >done properly from configure.
> > >
> > >--- trunk/libdha/Makefile       (original)
> > >+++ trunk/libdha/Makefile       Sat Mar 24 14:25:51 2007
> > >@@ -16,12 +16,6 @@ SRCS_MPLAYER = libdha.c \
> > >
> > >-ifeq ($(TARGET_OS),OpenBSD)
> > >-ifeq ($(TARGET_ARCH_X86),yes)
> > >-EXTRALIBS += -li386
> > >-endif
> > >-endif
> > 
> > It seems like libi386 is required for  i386_iopl() in pci_openbsd.c ,
> > #include "machine/sysarch.h".
> > 
> > In openbsd configure includes libi386 when win32loader is enabled. It
> > is always included  for netbsd (32bit arch).
> 
> Yes, I'm aware of this.  I thought about adding this unconditionally for
> OpenBSD, but I'm not sure if it's correct or not.

I've changed configure to add -li386 unconditionally on OpenBSD/x86_32
just like for NetBSD.  If there are problems they do not depend on
obscure configure options and we should hear about them quickly.

Diego