[MPlayer-cvslog] r22451 - trunk/libmpdemux/demux_avs.c

[Reimar Döffinger]

Hello,
On Sun, Mar 04, 2007 at 08:45:52PM +0200, Uoti Urpala wrote:
> On Sun, 2007-03-04 at 16:13 +0100, reimar wrote:
> > Remove hack that sets demuxer->video->pts after seeking, it seems no longer needed.
> 
> It's not needed for most of playback, but is still used by some code. At
> least EDL and external vobsub use it to seek to "the same position"
> after the main demuxer seek (before any packets are read which could
> tell the real new pts). Some other demuxers don't set it either though.
> It would be possible to change the code to do those seeks only after the
> next video frame is read.

Well, the comment said "for OSD", which obviously is not longer right.
But you remind me of something...
demux_demuxers also does this:

>  // Seek video
>  demux_seek(priv->vd,rel_seek_secs,audio_delay,flags);
>  // Get the new pos
>  pos = demuxer->video->pts;
>  if (!pos) {
>    demux_fill_buffer(priv->vd, demuxer->video);
>    if (demuxer->video->first)
>    pos = demuxer->video->first->pts;
>  }

Maybe something like this should just be done in demux_seek - set
demuxer->video->pts to MP_NOPTS_VALUE, do seeking stuff, and if it is
not set afterwards do a fill_buffer and set pts from first packet.
Opinions? I'm not in a hurry to implement it though.

Greetings,
Reimar Döffinger