[MPlayer-cvslog] r22356 - trunk/mplayer.c

[Uoti Urpala]

On Thu, 2007-03-01 at 00:46 +0100, Reimar Döffinger wrote:
> report on mplayer-users says
> mplayer file.avi -ss 00:10:00 -endpos 1:30 -loop 0
> starts from 0:0 after the first iteration with SVN.
> Can someone check if this is related to this commit? It seems the most
> likely one.

Yes it is caused by this commit. Per-file loop (but not if it's given as
a global setting) seeks back to 0 and then restores option variables.
That doesn't trigger a seek any more. It should be fixable by simply
changing the loop code to seek to the -ss position instead of 0.

Btw the way the loop code restores option variables in the middle of
playback is fundamentally broken. You can't just overwrite the variables
with new values after everything has already been initialized and expect
things to work. I'm not sure what to do about that - it would be easy to
just remove the variable changes, but perhaps some people depend on some
aspect of that...

To see the brokenness of per-file loop try for example to manually
adjust speed higher during playback. After loop it'll restore the speed
variable to 1 but won't change audio chain: result is video and audio at
different speeds. Or start with "-speed 100": at initialization the
speed is limited below 100 if there is audio, but loop reset sets it
back to 100 and limits aren't rechecked. So this time audio is at max
speed and video at speed 100.