[MPlayer-cvslog] r23727 - trunk/libdvdcss/libdvdcss.c

[Diego Biurrun]

On Tue, Jul 17, 2007 at 12:37:30AM +0200, Reimar Döffinger wrote:
> On Mon, Jul 16, 2007 at 11:24:17PM +0200, Diego Biurrun wrote:
> > On Sat, Jul 14, 2007 at 03:23:46PM +0200, Reimar Döffinger wrote:
> > > On Sat, Jul 14, 2007 at 02:50:00PM +0200, Diego Biurrun wrote:
> > > > On Sat, Jul 14, 2007 at 10:06:31AM +0200, Reimar Döffinger wrote:
> > > > > It is not a very relevant change though (esp. compared to  r23728).
> > > > > You could also cast all parameters to unsigned instead.
> > > > > IMO using sprintf (and even snprintf) here is a stupid idea anyway.
> > > > 
> > > > I'm asking because I wish to keep our diffs to upstream as small as
> > > > possible.  If r23728 is enough to solve the problem then this might as
> > > > well be reverted.
> > > 
> > > It solves the critical problem, but without it the format strings do not
> > > match the type, though I do not know on what type of system it will make
> > > a difference.
> > 
> > Umm, you mean Ivan's commit solves the critical problem while yours makes
> > the types match?
> > 
> > My point is that if your commit is more or less cosmetic then I would
> > suggest reverting it to minimize the diff towards upstream.
> 
> AFAICT sprintf behaviour is unspecified when the types mismatch as is
> the case without this patch.
> But actually this is moot, since AFAICT sprintf isn't really specified
> sufficiently to be used in this way if you are pedantic. Which is why I
> proposed a different patch on libdvdcss-devel - unfortunately the mails
> never got through, nor did I receive any of the mails sent, despite I
> received a confirmation mail that I was subscribed.
> I'll attach the mails I sent, since you found a magic way to get through
> the black hole they use as email filtering.

Do you get mails from the mailing list?  Otherwise it's probably time to
complain to their mailing list admin.

> Is there a chance of getting dvdcss upstream that is not just a joke (or
> more precisely a black hole)?

It worked for me when I sent Sam Hocevar personal emails and/or
contacted him through IRC, he used to be sam on freenode.

Nowadays I mostly go through Steve L'Homme, he is a VLC committer and
can commit to libdvdcss as well.  He is robUx4 on freenode and often
hangs out in the #ffmpeg channel.  He has funneled our last set of
libdvdcss patches into their repository.

Diego