[MPlayer-cvslog] r23703 - in trunk/gui: app.h mplayer/gmplayer.h mplayer/gtk/mb.h mplayer/gtk/opts.h mplayer/widgets.h skin/skin.h wm/ws.h wm/wskeys.h wm/wsxdnd.h

[Diego Biurrun]

On Tue, Jul 03, 2007 at 05:42:15PM +0300, Uoti Urpala wrote:
> > I was just splitting a big commit into pieces.  Removing the leading
> > underscores was the end goal and it's done now.
> 
> What do you mean by "splitting"? Didn't you change all of those lines
> again, thus not making the later commits any smaller? To me it looks
> like you made a big commit even bigger by committing completely useless
> partially-fixed versions AND then the fixed version.

Just removing the underscores made the GUI not compile anymore (some
multiple inclusion guards were duplicated), so I had to change those
first in order to be able to have one commit just remove the
underscores.  Some other inconsistencies I noticed in between and
committed them in batches as I found them.

Sure, I could have tried to do it all in one big change, but I like to
err on the side of too many, not too few commits and the other devs
mostly agree.

Diego