[MPlayer-cvslog] r22091 - trunk/configure

[Reimar Döffinger]

Hello,
On Wed, Jan 31, 2007 at 06:50:39PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 31 January 2007 at 17:52, Reimar Döffinger wrote:
> > On Wed, Jan 31, 2007 at 03:56:39PM +0100, Dominik 'Rathann' Mierzejewski wrote:
[...]
> > > Because it crashed on some GCC 3.x flavour while it worked with -O2 (which
> > > I specified in CFLAGS). IOW: I don't like configure overriding my CFLAGS choice.
> > 
> > Well, that is more an argument to keep it. Anything that causes people
> > running away screaming from broken compilers instead of producing broken
> > code is good...
> 
> No. It would still break when the default flags are used, just later
> (during compilation). However, second-guessing user overrides IS bad. If I
> want to shoot myself in the foot (i.e. use my own CFLAGS), then, by all
> means, let me do it! Not to mention that it's inconsistent with other
> detection stuff.

I was mostly joking, as said I agree with the change (though I seriously
do think that a compiler crash alone would not be a good reason for the
change - but I don't even know if that was meant as a reason for
removing it or just an explanation how you stumbled over it *g*).

Greetings,
Reimar Döffinger