[MPlayer-cvslog] r21895 - trunk/Gui/Makefile

[Reimar Döffinger]

Hello,
On Sat, Jan 13, 2007 at 10:33:26AM +0100, Diego Biurrun wrote:
> On Sat, Jan 13, 2007 at 10:12:04AM +0100, Guillaume POIRIER wrote:
> > On 1/13/07, diego <subversion at mplayerhq.hu> wrote:
> > >
> > >Modified:
> > >   trunk/Gui/Makefile
> > >
> > >Log:
> > >Do not add libavutil unconditionally to CFLAGS.
> > >
> > >--- trunk/Gui/Makefile  (original)
> > >+++ trunk/Gui/Makefile  Sat Jan 13 07:24:13 2007
> > >@@ -2,9 +2,11 @@
> > >
> > > LIBNAME = libgui.a
> > >
> > >-CFLAGS = -I../loader -I./wm -I./skin -I../libavutil/
> > >+CFLAGS = -I../loader -I./wm -I./skin
> > > #CFLAGS += -DDEBUG
> > >
> > >+CFLAGS-$(CONFIG_LIBAVUTIL)   += -I../libavutil
> > 
> > Although I do agree that your version is better than mine (thanks for
> > fixing it!), does it make sense to make a conditional assignment here
> > _if_ we can't build without lavu?
> 
> We should, otherwise it's a bug.  If we cannot, then libavutil can be
> unconditionally added to the CFLAGS everywhere.

? MPlayer can not build without libavutil, that was decided long ago.
It does not even work with only installed libavutil because bswap.h and
intreadwrite.h are not installed.
Though the -Ilibavutil might not be needed since I always include the
libavutil/ prefix when including headers.

Greetings,
Reimar Döffinger