[MPlayer-cvslog] r22345 - trunk/mpcommon.c

[Michael Niedermayer]

Hi

On Sun, Feb 25, 2007 at 11:21:47PM +0100, Diego Biurrun wrote:
> On Sun, Feb 25, 2007 at 10:01:25PM +0100, Reimar Döffinger wrote:
> > On Sun, Feb 25, 2007 at 09:53:46PM +0100, reimar wrote:
> > > 
> > > Added:
> > >    trunk/mpcommon.c
> > >       - copied, changed from r22250, /trunk/mplayer.c
> > > 
> > > Log:
> > > mpcommon.c is a partial copy of mplayer.c, so recommit it as such.
> > > Otherwise unchanged vs. r22251.
> > 
> > > +    int len;
> > > +    char type = d_dvdsub->sh ? ((sh_sub_t *)d_dvdsub->sh)->type : 'v';
> > > +    static subtitle subs;
> > > +    if (type == 'a')
> > > +#ifdef USE_ASS
> > > +      if (!ass_enabled)
> > 
> > Why is svn diff and svn blame etc. able to find the corresponding part
> > in mplayer.c but this thing is not? Does this use the normal diff
> > command? Then the -d option should be added IMO.
> 
> diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s                                                                        
> 
> Adding -d in there does indeed reduce the diff.  

could you also add -p ?


> Shall I trigger the
> commit log message to be resent?

no, if we want a message with a more readable diff then reimar could redo
the svn cp game that way we have 1 message per revision which IMHO is better

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20070226/5c8d9fe0/attachment.pgp>