[MPlayer-cvslog] r22162 - trunk/mplayer.c

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Feb 6 14:41:04 CET 2007


Hello,
On Tue, Feb 06, 2007 at 01:18:35AM +0100, uau wrote:
> Author: uau
> Date: Tue Feb  6 01:18:35 2007
> New Revision: 22162
> 
> Modified:
>    trunk/mplayer.c
> 
> Log:
> Fix multiple appearing or appearing+disappearing subs in the same frame 
> in non-ASS mode. The latter is common (old sub replaced by new) and 
> resulted in an incorrect frame where both appeared simultaneously.

Thanks for fixing my bugs ;-).
Do you know if this was a regression? I really tried to avoid changing
behaviour, but well...

> -        double nextpts = ds_get_next_pts(d_dvdsub);
> -        if (nextpts == MP_NOPTS_VALUE || nextpts > curpts)
> +        double pts = ds_get_next_pts(d_dvdsub);
> +        if (pts > curpts)
>            break;

Hmm... even if it works as it should with current MP_NOPTS_VALUE IMO it
would be a good idea to add an explicit check for it...

Greetings,
Reimar Doeffinger



More information about the MPlayer-cvslog mailing list