[MPlayer-cvslog] r25521 - trunk/libmpdemux/demux_ogg.c

[Compn]

On Mon, 24 Dec 2007 23:39:30 +0100, Reimar Döffinger wrote:

>Hello,
>On Mon, Dec 24, 2007 at 12:29:58PM -0500, Rich Felker wrote:
>> On Mon, Dec 24, 2007 at 04:56:34PM +0100, reimar wrote:
>> > -	   *flags = ((pack->granulepos & iframemask) == 0);
>> > +	   *flags = (pack->granulepos & iframemask) == 0;
>> 
>> C has the ! operator for a reason. It would make this code a lot more
>> readable. I would go so far as to say that any occurrance of "== 0"
>> in C is bad style but this is among the most blatant offenses.
>
>Firstly, this is not really my code so I mostly restrict myself to
>things I expect no discussion about.


looking at svn log ... looks like only you , nico, dalias , uau and
some outside patches have been comitted in the last 2 years.

has anyone seen moritz lately? did he leave or too busy for mplayer
development? 

is demux_ogg unmaintained? i know most devs hate ogg stuff.

-compn