[MPlayer-cvslog] r25521 - trunk/libmpdemux/demux_ogg.c
Rich Felker
dalias at aerifal.cx
Mon Dec 24 18:29:58 CET 2007
On Mon, Dec 24, 2007 at 04:56:34PM +0100, reimar wrote:
> - *flags = ((pack->granulepos & iframemask) == 0);
> + *flags = (pack->granulepos & iframemask) == 0;
C has the ! operator for a reason. It would make this code a lot more
readable. I would go so far as to say that any occurrance of "== 0" in
C is bad style but this is among the most blatant offenses.
Rich
More information about the MPlayer-cvslog
mailing list