[MPlayer-cvslog] r25301 - trunk/vidix/radeon_vid.c

[Ivan Kalvachev]

On Dec 6, 2007 8:54 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Dec 06, 2007 at 08:03:07AM +0100, Diego Biurrun wrote:
> > On Wed, Dec 05, 2007 at 04:22:47PM +0100, Reimar Döffinger wrote:
> > > On Wed, Dec 05, 2007 at 04:54:01PM +0200, Ivan Kalvachev wrote:
> > > > 2007/12/5, Diego Biurrun <diego at biurrun.de>:
> > > > > On Tue, Dec 04, 2007 at 11:22:24PM +0100, ben wrote:
> > > > > >
> > > > > > Log:
> > > > > > sync with vidix.sf.net r320: ati radeon >= R5xx do no more have overlay engine but use 3D texture mapping instead, hence no chance to be supported by this driver
> > > > >
> > > > > Please keep lines below 80 characters, thank you.
> > > >
> > > > Would you explain why is this required?
> > >
> > > Required seems a bit strong to me, but I see several reasons:
> > > More than that and it
> > > 1) becomes ugly when quoting in an email
> > > 2) the line breaks are more or less at "random" points which can easily
> > >    harder to read than doing the break at an appropriate place
> > > 3) Lines longer than 80 lines very fast become really hard to read, at
> > >    least for me (actually the limit is more around 65 lines, but 80
> > >    is bearable), which also means a larger terminal is not a solution to
> > >    point 2.
> >
> > Furthermore, not all programs that handle commit messages insert line
> > breaks at all!  ViewVC does not for example, which makes overly long
> > lines in commit messages particularly annoying.
>
> ehm, ViewVC cannot insert line breaks because it doesnt know your
> screen/window/terminal size
>
> the bug in ViewVC is that it uses <pre> tags which is just WRONG
> it shouls just use p and insert <br/> where ones were in the original msgs
>
> also the fact that besides svn clients which break lines there exist buggy
> ones which do not is hardly an argument for the way svn log messages should be
> written.

He,he, I see ViewVC like this (main view):
---
Fix warning: cpudetect.c: In function 'check_os_katmai_support':
 cpudetect.c:395...
---

However I don't see any kind of problem when viewing particular file (view=log).
The message is normal:
---
Fix warning:
cpudetect.c: In function 'check_os_katmai_support':
cpudetect.c:395: warning: unused variable 'saved_sigfpe'
---
Also this mode doesn't seem to have any limitations on the line length
and I can easily read up to 130 characters per line. In that mode the
browser doesn't have problem in breaking too long lines at word
boundary.
It is also the only mode that shows the whole message.

I think that the main view removes line breaks on purpose so it can
display at once as much information as possible. Then cuts it where it
think the line would end, failing miserable if setup is different.
Additional line breaks are absolutely useless in the main view.


Most of the time I had to look at log messages is when backtracking
some bug and it's always been in view=log mode.
So I tune my messages for it.
I also never had any readablity problems with commit messages in mails,
so I've never cared how they would look in mail.
Replying to -cvs mail is even more rarer.