[MPlayer-cvslog] r25301 - trunk/vidix/radeon_vid.c

Diego Biurrun diego at biurrun.de
Thu Dec 6 08:03:07 CET 2007


On Wed, Dec 05, 2007 at 04:22:47PM +0100, Reimar Döffinger wrote:
> On Wed, Dec 05, 2007 at 04:54:01PM +0200, Ivan Kalvachev wrote:
> > 2007/12/5, Diego Biurrun <diego at biurrun.de>:
> > > On Tue, Dec 04, 2007 at 11:22:24PM +0100, ben wrote:
> > > >
> > > > Log:
> > > > sync with vidix.sf.net r320: ati radeon >= R5xx do no more have overlay engine but use 3D texture mapping instead, hence no chance to be supported by this driver
> > >
> > > Please keep lines below 80 characters, thank you.
> > 
> > Would you explain why is this required?
> 
> Required seems a bit strong to me, but I see several reasons:
> More than that and it
> 1) becomes ugly when quoting in an email
> 2) the line breaks are more or less at "random" points which can easily
>    harder to read than doing the break at an appropriate place
> 3) Lines longer than 80 lines very fast become really hard to read, at
>    least for me (actually the limit is more around 65 lines, but 80
>    is bearable), which also means a larger terminal is not a solution to
>    point 2.

Furthermore, not all programs that handle commit messages insert line
breaks at all!  ViewVC does not for example, which makes overly long
lines in commit messages particularly annoying.

Diego



More information about the MPlayer-cvslog mailing list