[MPlayer-cvslog] r25281 - trunk/libmpcodecs/dec_audio.c

[Uoti Urpala]

On Tue, 2007-12-04 at 18:33 +0100, Reimar Döffinger wrote:
> On Tue, Dec 04, 2007 at 05:37:00PM +0200, Uoti Urpala wrote:
> > On Mon, 2007-12-03 at 10:07 +0100, rfelker wrote:
> > > Log:
> > > fix declaration after statement, take 2
> > 
> > Do not commit code uglifications like this. I'll revert this later (at
> > least before next changing the code).
> 
> This is not only about ugliness and you seem to be the only one
> considering it really uglier AFAICT (objections welcome).

This commit moved setting the values of the struct away from where
they're used. Additionally it introduced a bug. Then to fix that he
added a workaround which moves the initialization of one field away from
the others. Just how is that not uglier?

> And reverting seems like a rather straight way to a commit war to me,
> which I wouldn't find funny. Not at all.

What's the alternative? Having him try to change all the code I write is
not a working long-term solution.

Rich should understand that he is in no position to insist on his view.
If he wants to abuse his svn account, which he rarely uses for useful
development, to have a commit war with an active developer then he
should lose it.