[MPlayer-cvslog] r24262 - in trunk: Makefile command.c get_path.c get_path.h gui/cfg.c gui/interface.c gui/interface.h input/input.c libaf/af_export.c libass/ass_mp.c libmpcodecs/dec_audio.c libmpcodecs/dec_video.c libvo/font_load.c libvo/font_load_ft.c libvo/vo_dxr2.c mencoder.c mp_core.h mplayer.c stream/stream_dvb.c

[Diego Biurrun]

On Wed, Aug 29, 2007 at 10:10:37AM +0800, JonY wrote:
> Diego Biurrun wrote:
> > On Tue, Aug 28, 2007 at 07:31:15PM +0200, Reimar Doeffinger wrote:
> >> On Tue, Aug 28, 2007 at 11:39:34PM +0800, JonY wrote:
> >> [...]
> >>> get_path.o get_path.c
> >>> get_path.c: In function 'get_path':
> >>> get_path.c:49: warning: implicit declaration of function 
> >>> 'GetModuleFileNameA'
> >>> get_path.c: In function 'set_path_env':
> >>> get_path.c:146: warning: implicit declaration of function 
> >>> 'SetEnvironmentVariableA'
> >> Obviously a prototype is missing for this function, thus it is compiled
> >> with wrong calling conventions, which either results in it not linking
> >> or a crash during execution...
> > 
> > Yes, that's likely the cause.  Could somebody please try adding
> > 
> > #include <windows.h>
> > 
> > to get_path.c, it might solve the problem.
> 
> OK, adding #include <windows.h> fixed it, tried it on r24280.

Fix committed, thanks for testing.

Diego

P.S.: Please remove mailing list footers etc. from your quotes, thank
you.