[MPlayer-cvslog] r24153 - trunk/libvo/vo_xv.c

[Reimar Döffinger]

Hello,
On Sat, Aug 25, 2007 at 12:05:51PM -0400, Rich Felker wrote:
> On Sat, Aug 25, 2007 at 09:38:14AM +0200, Reimar Döffinger wrote:
> > On Sat, Aug 25, 2007 at 06:28:17AM +0200, uau wrote:
> > > +    mp_input_rm_event_fd(ConnectionNumber(mDisplay));
> > 
> > And where did you get the guarantees that ConnectionNumber returns a
> > valid fd? My man page says nothing to that effect.
> 
> The man page is incomplete; this is the whole point of
> ConnectionNumber. It's documented in the xlib manual or something. The
> return of ConnectionNumber might be unspecified on non-POSIX OS's but
> the X standards make additional requirements like this on a POSIX OS,
> IIRC.

Hmm... I do have a MinGW MPlayer build with X support. Not sure if it
matters though, since it has no have posix-select so this code might not
make any difference there.

Greetings,
Reimar Döffinger