[MPlayer-cvslog] r24147 - trunk/input/input.c

[Reimar Döffinger]

Hello,
On Sat, Aug 25, 2007 at 06:28:04AM +0200, uau wrote:
> Author: uau
> Date: Sat Aug 25 06:28:04 2007
> New Revision: 24147
> 
> Log:
> Use bitfield instead of manual bit fiddling in input.c

I really should listen more to my intuition.

> -  if(!select)
> -    cmd_fds[num_cmd_fd].flags = MP_FD_NO_SELECT;
> +  cmd_fds[num_cmd_fd].no_select = !select;

This completely breaks MPlayer on x84_64 with gcc 4.2.0 becasue
no_select gets never set.
For the future let's remember: think of how stupid a compiler could be
at worst and the subtract a bit. And after that, decide which features
to use.

Greetings,
Reimar Döffinger