[MPlayer-cvslog] r23994 - trunk/libmpcodecs/ad_ffmpeg.c

[Michael Niedermayer]

Hi

On Thu, Aug 02, 2007 at 10:37:43AM +0200, Reimar Döffinger wrote:
> Hello,
> On Thu, Aug 02, 2007 at 02:47:38AM +0300, Uoti Urpala wrote:
> > On Thu, 2007-08-02 at 01:36 +0200, reimar wrote:
> > > Set lavc_context->channels before opening the codec, it is sufficient to
> > > select the desired number of codecs for ffdca and does not break other codecs
> > > like ffvorbis that do not (re)set the channel number during decode.
> > 
> > > +    // Set desired number of channels
> > > +    lavc_context->channels = audio_output_channels;
> > >      /* open it */
> > 
> > This overrides the value from the earlier line
> > 	lavc_context->channels = sh_audio->wf->nChannels;
> > which now becomes meaningless. Is it guaranteed that no codec needs this
> > information? If the number of channels IS guaranteed to always be
> > available from extradata or whatever and the above line can be removed,
> > then what about the other values set in the same block?
> 
> Oh crap. I guess I'll send a patch again next time. Honestly, I don't
> really know how to handle it, but I think the API is broken.

yes


> IMO an extra field should be added to the codec context to contain this
> information.

yes, and patch welcome

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20070803/4e470d50/attachment.pgp>