[MPlayer-cvslog] r23998 - trunk/libmpcodecs/ad_ffmpeg.c

uau subversion at mplayerhq.hu
Thu Aug 2 23:54:14 CEST 2007


Author: uau
Date: Thu Aug  2 23:54:14 2007
New Revision: 23998

Log:
Revert setting audio output channel count for FFmpeg

The FFmpeg API needs to be fixed before this can be done sanely.
ffdca wants the desired output channel count to be set in
avctx->channels. Unfortunately it also completely fails if the requested
number of channels is not available rather than returning a different
amount (if 6 channels are requested we'd probably rather use stereo than
fail completely).
ffvorbis ignores caller-set values in avctx->channels. It writes the
channel count there once during init. This means the caller can only
set the count before init because later there would be no indication
whether the channel count in avctx reflects real output.
ffwma requires the caller to supply the encoded channel count
in avctx->channels during init or it fails. So it is not possible to
set a different number of desired output channels there before init
either.


Modified:
   trunk/libmpcodecs/ad_ffmpeg.c

Modified: trunk/libmpcodecs/ad_ffmpeg.c
==============================================================================
--- trunk/libmpcodecs/ad_ffmpeg.c	(original)
+++ trunk/libmpcodecs/ad_ffmpeg.c	Thu Aug  2 23:54:14 2007
@@ -86,8 +86,6 @@ static int init(sh_audio_t *sh_audio)
                lavc_context->extradata_size);	
     }
 
-    // Set desired number of channels
-    lavc_context->channels = audio_output_channels;
     /* open it */
     if (avcodec_open(lavc_context, lavc_codec) < 0) {
         mp_msg(MSGT_DECAUDIO,MSGL_ERR, MSGTR_CantOpenCodec);



More information about the MPlayer-cvslog mailing list