[MPlayer-cvslog] r23994 - trunk/libmpcodecs/ad_ffmpeg.c

[Uoti Urpala]

On Thu, 2007-08-02 at 01:36 +0200, reimar wrote:
> Set lavc_context->channels before opening the codec, it is sufficient to
> select the desired number of codecs for ffdca and does not break other codecs
> like ffvorbis that do not (re)set the channel number during decode.

> +    // Set desired number of channels
> +    lavc_context->channels = audio_output_channels;
>      /* open it */

This overrides the value from the earlier line
	lavc_context->channels = sh_audio->wf->nChannels;
which now becomes meaningless. Is it guaranteed that no codec needs this
information? If the number of channels IS guaranteed to always be
available from extradata or whatever and the above line can be removed,
then what about the other values set in the same block?