[MPlayer-cvslog] r23152 - in trunk: DOCS/man/en/mplayer.1 cfg-common.h libass/ass.h libass/ass_font.c libass/ass_font.h libass/ass_mp.c libass/ass_mp.h libass/ass_render.c libmpcodecs/vf_ass.c libmpcodecs/vf_vo.c libmpcodecs/vfcap.h libvo/vo_gl.c

[Evgeniy Stepanov]

On Friday 27 April 2007 19:35, Reimar Döffinger wrote:
> Hello,
>
> On Fri, Apr 27, 2007 at 05:33:12PM +0200, Reimar D?ffinger wrote:
> > On Fri, Apr 27, 2007 at 04:25:36PM +0200, eugeni wrote:
> > [...]
> >
> > > Modified: trunk/libvo/vo_gl.c
> > > =======================================================================
> > >======= --- trunk/libvo/vo_gl.c	(original)
> > > +++ trunk/libvo/vo_gl.c	Fri Apr 27 16:25:36 2007
> > > @@ -792,7 +792,7 @@ query_format(uint32_t format)
> > >                 VFCAP_FLIP |
> > >                 VFCAP_HWSCALE_UP | VFCAP_HWSCALE_DOWN |
> > > VFCAP_ACCEPT_STRIDE; if (use_osd)
> > > -      caps |= VFCAP_OSD | VFCAP_EOSD;
> > > +      caps |= VFCAP_OSD | VFCAP_EOSD | VFCAP_EOSD_UNSCALED;
> > >      if ((format == IMGFMT_RGB24) || (format == IMGFMT_RGBA))
> > >          return caps;
> > >      if (use_yuv && format == IMGFMT_YV12)
> >
> > It is not a big deal, but you are supposed to send patches first for
> > code you don't maintain. Which has a good reason since this is wrong,
> > vo_gl supports scaled OSD, even though it is currently buggy.
>
> Ups, you did send the patch, I just didn't notice it changed vo_gl.c.
> Sorry for the mistake.

No problem. I applied it too fast, it was sent to -dev less then 2 days ago.

So, -vo gl supports both scaled and unscaled OSD ? What does it depend on, and 
why is it needed ?