[MPlayer-cvslog] r23139 - in trunk: libmpcodecs/ae_lavc.c libmpcodecs/vf.c libmpdemux/demuxer.c libmpdemux/muxer.c

[Diego Biurrun]

On Thu, Apr 26, 2007 at 05:20:27PM +0200, Nico Sabbi wrote:
> diego wrote:
> 
> >Log:
> >Simplify preprocessor directives: There is a general variable for
> >static/shared FFmpeg libraries now.
> >
> >--- trunk/libmpcodecs/ae_lavc.c	(original)
> >+++ trunk/libmpcodecs/ae_lavc.c	Thu Apr 26 17:10:07 2007
> >@@ -28,7 +28,7 @@ extern int  lavc_param_atag;
> > static int compressed_frame_size = 0;
> >-#if defined(USE_LIBAVFORMAT) ||  defined(USE_LIBAVFORMAT_SO)
> >+#ifdef USE_LIBAVFORMAT
> > #ifdef USE_LIBAVFORMAT_SO
> >
> why??? it's disgusting. It leads to the same mess that a unified 
> USE_LIBAVCODEC introduced;
> 
> We had already talked about it in the past, and I believe that we
> agreed that eventually the opposite should have been made:
> distinguishing between USE_LIBAVCODEC and USE_LIBAVCODEC_SO

I don't follow you here.  What exactly is the problem?  AFAICT I did
what you are suggesting ...

Diego