[MPlayer-cvslog] r23058 - trunk/vidix/pm2_vid.c

[Reimar Döffinger]

Hello,
On Sat, Apr 21, 2007 at 02:04:49PM +0200, ben wrote:
> Author: ben
> Date: Sat Apr 21 14:04:49 2007
> New Revision: 23058
> 
> Modified:
>    trunk/vidix/pm2_vid.c
> 
> Log:
> fix for mingw: u_long becomes unsigned long
> 
> Modified: trunk/vidix/pm2_vid.c
> ==============================================================================
> --- trunk/vidix/pm2_vid.c	(original)
> +++ trunk/vidix/pm2_vid.c	Sat Apr 21 14:04:49 2007
> @@ -48,7 +48,7 @@
>  #endif
>  
>  #define WRITE_REG(offset,val)						\
> -    *(volatile u_long *)(((unsigned char *)(pm2_reg_base)) + offset) = (val)
> +    *(volatile unsigned long *)(((unsigned char *)(pm2_reg_base)) + offset) = (val)
>  #define READ_REG(offset)						    \
>      *(volatile unsigned long *)(((unsigned char *)(pm2_reg_base)) + offset)

Are you sure long is what you want? Long is 64 bits on AMD64 and 32 bit
on 32bit systems, I find it hard to imagine that the registers suddenly
double their size...
This might be a point where uint32_t makes sense...
The number of () seems a bit overkill, too...

Greetings,
Reimar Döffinger