[MPlayer-cvslog] r22987 - trunk/stream/tv.c

[The Wanderer]

Reimar Döffinger wrote:

> Hello,
> On Fri, Apr 13, 2007 at 04:34:38PM +0200, voroshil wrote:
> 
>> Author: voroshil
>> Date: Fri Apr 13 16:34:38 2007
>> New Revision: 22987
>> 
>> Modified:
>>    trunk/stream/tv.c
>> 
>> Log:
>> cosmetics. restore empty line removed in previous commit.
> 
> Minor nit: avoid writing only "previous commit", either also mention 
> which file the previous commit changed or also explicitly state the 
> revision number.
> 
> With SVN it is easily possible that someone commits before you and
> you don't have a chance to notice (like it actually happened in this
> case).

The phrasing could still be considered valid; it could be read as
meaning "the previous commit to this file", whatever commit that was. I
have refrained from mentioning this at least once in the past on the
basis that I did not know that that was not the intention.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.