[MPlayer-cvslog] r19982 - trunk/stream/stream_pvr.c

[Nico Sabbi]

Benjamin Zores wrote:

>On Mon, 25 Sep 2006 22:36:45 +0200 (CEST)
>ben <subversion at mplayerhq.hu> wrote:
>
>  
>
>>Author: ben
>>Date: Mon Sep 25 22:36:45 2006
>>New Revision: 19982
>>
>>Modified:
>>   trunk/stream/stream_pvr.c
>>
>>Log:
>>cosmetic renames because pvr support will soon be less ivtv driver dependant
>>    
>>
>
>For info, with Linux 2.6.18 comes the introduction of a native MPEG encoding API,
>shared among drivers which is no longer IVTV specific/related. However, for now, it's an MPEG encoding API _only_ (no decoding) i.e you can grab MPEG streams but not output MPEG to the card.
>
>This means that the PVR input will be usable by all CX2341X based cards (like ivtv, but also pvrusb2, the cx88 blackbird cards and a Philips MPEG encoder).
>I will add support for this new V4L2 MPEG encoding API in stream_pvr within the next days but before that, quick poll:
>
>1. should I deprecate old ivtv related code in favor of new V4L2 MPEG API ?
>  
>
since support for pvr was added very recently I'd say yes

>In this case, stream_pvr won't be usable any longer with kernels prior to 2.6.18.
>It's easier for me, that's for sure, but for that, in order to compile and so set the right define in config.h, the configure script needs to detect that the linux/videodev2.h comes from a Linux 2.6.18+ based kernel. Is this doable ?
>
>2. I can put ifdef KERNEL_VERSION >= 2.6.18 checks all around the code in order to either
>use old or new API.
>
>Opinions ?
>
>Ben
>
>  
>
why don't you add to the detection section in configure a test program 
with all the
necessary checks and fail otherwise?