[MPlayer-cvslog] r20527 - trunk/configure

[Guillaume POIRIER]

Hi,

On 10/30/06, Diego Biurrun <diego at biurrun.de> wrote:
> On Mon, Oct 30, 2006 at 10:11:54AM +0100, Guillaume Poirier wrote:
> >
> > diego wrote:
> > >
> > > Modified:
> > >    trunk/configure
> > >
> > > Log:
> > > Fix libmpdvdkit2 linking on Mac OS X.
> > >
> > > --- trunk/configure (original)
> > > +++ trunk/configure Mon Oct 30 10:08:19 2006
> > > @@ -5209,6 +5209,7 @@
> > >      else
> > >        if darwin ; then
> > >         _def_dvd_darwin='#define DARWIN_DVD_IOCTL'
> > > +       _macosx_frameworks="$_macosx_frameworks -framework IOKit"
> >
> > Though I trust your judgment regarding how things should be
> > implemented in configure, shouldn't configure test if IOKit framework
> > exists, and enable libmpdvdkit2 only it it exists?
> >
> > Now, maybe it's such a basic lib/framework that we can safely assume
> > that if you're on OSX, it's always there.... I don't know.
>
> My system is pretty vanilla apart from installing Xcode, so I assume
> this is safe..

I feared that IOKit could exist only in recent version of OSX, but
apparently it's there from day one:
http://developer.apple.com/documentation/DeviceDrivers/Conceptual/IOKitFundamentals/index.html

So I'm relieved, we can really assume that it's there, provided that
we know that the OS is OSX (I don't know if darwin as it too).

Guillaume
-- 
With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has
a lead on USA on selling out individuals right to corporations!
Vive la France!