[MPlayer-cvslog] r21242 - trunk/bswap.h

[Rich Felker]

On Tue, Nov 28, 2006 at 06:59:38PM +0100, Reimar Döffinger wrote:
> Hello,
> On Tue, Nov 28, 2006 at 06:38:18PM +0100, Diego Biurrun wrote:
> > BTW, what about merging all of our bswap.h into FFmpeg's?  Only
> > bswap_dbl and bswap_ldbl are used in any case.  The license should be no
> > problem, I'm sure Reimar will be willing to make it LGPL.
> 
> They are a hack and not really correct (esp. since fpu endianness can
> differ from int endianness). The two places or so where they are used should
> be fixed to use the float reading code from lavu.

Umm, native cpu double/ldbl should never be used for reading/writing
binary data. Instead you should use the specialized reader/writer
functions which are portable. Thus bswap is never needed.

Rich