[MPlayer-cvslog] r21306 - in trunk: help/help_mp-en.h loader/Makefile loader/ldt_keeper.c loader/module.c loader/stubs.S loader/stubs.s loader/wine/poppack.h mp_msg.h

[Reimar Doeffinger]

Hello,
On Mon, Nov 27, 2006 at 01:29:18PM +0100, Reimar Doeffinger wrote:
> On Mon, Nov 27, 2006 at 03:44:07AM +0100, nplourde wrote:
> > Copied: trunk/loader/stubs.S (from r21265, /trunk/loader/stubs.s)
> > ==============================================================================
> > --- /trunk/loader/stubs.s	(original)
> > +++ trunk/loader/stubs.S	Mon Nov 27 03:44:06 2006
> > @@ -1,8 +1,13 @@
> > +#if defined(__APPLE__) || defined(__OpenBSD__)
> > +# define SYM(x) _ ## x
> > +#else
> > +# define SYM(x) x
> > +#endif
> 
> Why not use MANGLE() like all the other asm code?

Ok, not possible, that works only for inline asm. But the ||
defined(__OpenBSD__) seems wrong (according to the commit that removed
loader_objfix.sh) and will make this stuff work only on very old non-ELF
OpenBSD.

Greetings,
Reimar D?ffinger