[MPlayer-cvslog] r21306 - in trunk: help/help_mp-en.h loader/Makefile loader/ldt_keeper.c loader/module.c loader/stubs.S loader/stubs.s loader/wine/poppack.h mp_msg.h

[Nicolas Plourde]

On 27-Nov-06, at 4:48 AM, Reimar Doeffinger wrote:

> Hello,
> On Mon, Nov 27, 2006 at 11:23:47AM +0200, Uoti Urpala wrote:
>> On Mon, 2006-11-27 at 10:08 +0100, Reimar Doeffinger wrote:
>>> On Mon, Nov 27, 2006 at 03:44:07AM +0100, nplourde wrote:
>>>> fix compilation for win32 dll codec support for intel osx
>>>
>>> The last patch to loader completely broke DLL loading because nobody
>>> tested it on linux before it was applied. I don't think it is my  
>>> job to
>>> clean up after other people's patches for what I consider a total  
>>> fronge
>>> OS (and proprietary in addition).
>>
>> I just tested and it still seems to work at least with some dlls.  
>> What
>> did it break? And if it really did break things severely how about
>> reverting it?
>
> I already fixed it. And I have to admit that it was probably a  
> change I
> suggested on -dev-eng that broke it. Nevertheless I am highly allergic
> to this "apply first fix later style". And as long as SVN policy is  
> with
> me on that I insist I have a right to be.
>

Well sorry about that, but with the current commit frenzy I was in a  
hurry to commit before the patch was again incompatible.  And the  
build is still broken on Mac OSX build break are wasting other devs  
time as much as bug.

====
Nicolas Plourde <nicolas.plourde at gmail.com>