[MPlayer-cvslog] r21306 - in trunk: help/help_mp-en.h loader/Makefile loader/ldt_keeper.c loader/module.c loader/stubs.S loader/stubs.s loader/wine/poppack.h mp_msg.h

[Dominik 'Rathann' Mierzejewski]

On Monday, 27 November 2006 at 11:09, Uoti Urpala wrote:
> On Mon, 2006-11-27 at 10:48 +0100, Reimar Doeffinger wrote:
> 
> > > On Mon, 2006-11-27 at 10:08 +0100, Reimar Doeffinger wrote:
> > > > The last patch to loader completely broke DLL loading because nobody
> 
> > I already fixed it. And I have to admit that it was probably a change I
> 
> You were talking about an earlier commit? I thought you meant the commit
> you replied to broke something.
> 
> > suggested on -dev-eng that broke it. Nevertheless I am highly allergic
> > to this "apply first fix later style". And as long as SVN policy is with
> > me on that I insist I have a right to be.
> 
> If someone breaks compilation or runtime too often that's bad of course,
> but IMO if that happens it doesn't matter much if they break things by
> commits to code they're the primary maintainer of or by commits to other
> code.

IMHO it does matter. If somebody breaks their own code, it's less of a
transgression than when they break code they don't maintain. It should
be taken for granted that you have to be extra careful when committing
patches to other people's code.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan