[MPlayer-cvslog] r21242 - trunk/bswap.h

[Reimar Döffinger]

Hello,
On Sat, Nov 25, 2006 at 10:46:13PM +0100, Reimar D?ffinger wrote:
> On Sat, Nov 25, 2006 at 07:30:44PM +0100, reimar wrote:
> > Author: reimar
> > Date: Sat Nov 25 19:30:44 2006
> > New Revision: 21242
> > 
> > Modified:
> >    trunk/bswap.h
> > 
> > Log:
> > Reuse bswap.h from libavutil. Will only work when libavutil subdir is available.
> > Applied at Diego's request.
> 
> This broke compilation on some bigendian systems, because in libavutil
> bswap_32 is a function, not a macro.
> Attached patch just removes that (IMO) horrible initialization in
> ao_pcm.c.

Applied, since there is no reason le2me_32 of a constant expression has
to be a constant expression, thus the old code was just wrong.

> Btw. all bswap.h files have #ifdef HAVE_BYTESWAP_H part, but we never
> define HAVE_BYTESWAP_H, is that intentional or did just nobody write a
> configure test?

I'm still interested in this subject *g*

Greetings,
Reimar Döffinger