[MPlayer-cvslog] r21213 - in trunk/stream: stream_dvdnav.c stream_dvdnav.h

[Guillaume POIRIER]

Hi,

<watchdog mode="on">

On 11/25/06, nicodvb <subversion at mplayerhq.hu> wrote:
> Author: nicodvb
> Date: Sat Nov 25 13:17:34 2006
> New Revision: 21213
>
> Modified:
>    trunk/stream/stream_dvdnav.c
>    trunk/stream/stream_dvdnav.h
>
> Log:
> added code to identify subs language and count; needed for forthcoming support for -slang
>
> Modified: trunk/stream/stream_dvdnav.c
> ==============================================================================
> --- trunk/stream/stream_dvdnav.c        (original)
> +++ trunk/stream/stream_dvdnav.c        Sat Nov 25 13:17:34 2006
> @@ -476,6 +476,34 @@
>    priv->mousey = y;
>  }
>
> +int dvdnav_sid_from_lang(stream_t *stream, unsigned char *language) {
> +  dvdnav_priv_t * priv=(dvdnav_priv_t*)stream->priv;

Wouldn't it be nice to have doxygen comments here?
Yes, what it does is pretty obvious... but it wouldn't hurt to say,
know if *language is a 2 letter or 3 letter code, blah blah :-)


> +int dvdnav_number_of_subs(stream_t *stream) {

this one probably doesn't need any ;-)

Guillaume
-- 
With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has
a lead on USA on selling out individuals right to corporations!
Vive la France!