[MPlayer-cvslog] r20579 - trunk/libmpdvdkit2/common.h

[Rich Felker]

On Sun, Nov 05, 2006 at 03:58:24PM +0200, Jan Knutar wrote:
> On Sunday 05 November 2006 12:41, Guillaume POIRIER wrote:
> 
> > > > >  /* several type definitions */
> > > > >  #   if defined( __MINGW32__ )
> > > > > -#       define lseek _lseeki64
> > > > > +#       define lseek64 _lseeki64
> > > >
> > > > This MUST be fixed in the code. The lseek64 function is invalid
> > > > LFS-ism. Please revert and fix mpdvdkit instead, regardless of whether
> > > > the upstream will accept the fix, since it's blatently wrong.
> > >
> > > What's LFS?
> > 
> > I assume it's "Linux From Scratch". Rich ususally writes "gnuism" when
> > talking about FSF stuff...
> 
> In this context I'd be more inclined to think it's "Large File Support", which
> if I don't remember wrong, is according to Rich some ill-designed standard
> by some committee.

Yes, this is what I meant. S is either Support or Summit, I forget
which. And yes, basically it was a committee that designed a horrible
way of introducing ugly *64 functions and broken semantics for
interaction between the normal and *64 functions instead of just
fixing changing everything to use 64bit offsets and keeping around an
old libc with different ABI for legacy apps that haven't yet been
recompiled...

Rich