[MPlayer-cvslog] r20582 - trunk/configure

[Rich Felker]

On Sat, Nov 04, 2006 at 09:41:55PM +0100, Reimar Döffinger wrote:
> Hello,
> On Sat, Nov 04, 2006 at 03:59:11PM -0500, Rich Felker wrote:
> > On Wed, Nov 01, 2006 at 06:05:19PM +0100, reimar wrote:
> > > Author: reimar
> > > Date: Wed Nov  1 18:05:17 2006
> > > New Revision: 20582
> > > 
> > > Modified:
> > >    trunk/configure
> > > 
> > > Log:
> > > gcc optimized != 0 check for extern function away, thus linking
> > > would still always succeed in cdda and cdio tests.
> > > 
> > > 
> > > Modified: trunk/configure
> > > ==============================================================================
> > > --- trunk/configure	(original)
> > > +++ trunk/configure	Wed Nov  1 18:05:17 2006
> > > @@ -5288,7 +5288,7 @@
> > >  // This need a better test. How ?
> > >  int main(void) {
> > >      void *test = cdda_verbose_set;
> > > -    return !test;
> > > +    return test == (void *)1;
> > 
> > Um why not just call a function?
> 
> Because in the previous versions executing the file was part of the
> check and the only function that wouldn't have crashed was the init
> function, but that would have needed around 3 #ifdefs depending on the
> system etc.

Any check that involves execution should be strictly forbidden in
configure. It breaks cross-compiling.

> Since it is no longer executed using a crashy function would be okay
> now, but I'm not motivated to change it now.

Fair enough..

Rich