[MPlayer-cvslog] r20655 - trunk/libmpcodecs/vd_libmpeg2.c

[Rich Felker]

On Sat, Nov 04, 2006 at 01:15:15PM +0100, Reimar Döffinger wrote:
> Hello,
> On Sat, Nov 04, 2006 at 08:08:54AM +0100, henry wrote:
> > Author: henry
> > Date: Sat Nov  4 08:08:54 2006
> > New Revision: 20655
> > 
> > Modified:
> >    trunk/libmpcodecs/vd_libmpeg2.c
> > 
> > Log:
> > pass the interlacing info to the filter chain
> > 
> > Modified: trunk/libmpcodecs/vd_libmpeg2.c
> > ==============================================================================
> > --- trunk/libmpcodecs/vd_libmpeg2.c	(original)
> > +++ trunk/libmpcodecs/vd_libmpeg2.c	Sat Nov  4 08:08:54 2006
> > @@ -221,6 +221,8 @@
> >  		mpi_new->fields |= MP_IMGFIELD_REPEAT_FIRST;
> >  	    else mpi_new->fields &= ~MP_IMGFIELD_REPEAT_FIRST;
> >  	    mpi_new->fields |= MP_IMGFIELD_ORDERED;
> > +            if (!(info->current_picture->flags&PIC_FLAG_PROGRESSIVE_FRAME))
> > +                mpi_new->fields |= MP_IMGFIELD_INTERLACED;
> 
> You're using spaces-only indentation whereas all the surrounding code
> uses tabs+space. Please keep to the style of the surrounding code in the
> future.

As long as the surrounding code is mixed (i.e. ugly mess) I don't
think consistency really matters. Of course spaces should be banned in
clean tab-indented code and tabs should likewise be forbidden in clean
space-indented code, but I don't see a need to enforce any rule in the
situation here..

Rich