[MPlayer-cvslog] CVS: main/libvo vo_s3fb.c, NONE, 1.1 video_out.c, 1.107, 1.108

[Guillaume POIRIER]

Hi,

On 5/18/06, Ivo <ivop at euronet.nl> wrote:
> On Wednesday 17 May 2006 23:56, Guillaume POIRIER wrote:
> > Neither do I. Please modify and commit your changes yourself (except
> > maybe printfs). It's be much less error-prone than if I do it myself.
>
> Done (the #include stuff and printf->mp_msg). If I am bored, I might move
> the messages to help_mp-en.h and give the translators something to do ;)

Thanks a lot. That's really nice of you. :-)



> > If you see more problems, don't hesitate to go ahead and commit your
> > changes.
>
> I'm a little hesitant about that, as I cannot test if the functionality
> remains the same because I lack the hardware to do so.
>
> Well, there is the following construct:
>
> if smem == -1
>         blah
>         if smem != -1
>                 blah
>
> which can obviously never be true. Also, the fd associated with smem is not
> closed. I suppose it should. The original author should have a look at
> this.

I included the author in this reply. He will hopefully have a look at this.


> > This code has been sitting on mplayer-dev with no review whatsoever,
> > so I'm not surprised that it doesn't meet our coding standards.
>
> Commiting is always a good way to grasp people's attention ;)

Sad, but true.

Guillaume

-- 
An Israeli man's life was saved when he was given a Palestinian man's
heart in a heart transplant operation. The guy is doing fine, but the
bad news is, he can't stop throwing rocks at himself.
  -- Jay Leno