[MPlayer-cvslog] CVS: main/libao2 ao_pcm.c,1.33,1.34

[Diego Biurrun]

On Sun, May 14, 2006 at 01:28:29PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Sunday, 14 May 2006 at 12:21, Diego Biurrun CVS wrote:
> > 
> > Modified Files:
> > 	ao_pcm.c 
> > Log Message:
> > Only set the default output filename when it was not passed on the command
> > line.  Noticed by Corey Hickey.
> > 
> > --- ao_pcm.c	13 May 2006 19:04:39 -0000	1.33
> > +++ ao_pcm.c	14 May 2006 10:21:56 -0000	1.34
> > @@ -93,9 +93,10 @@
> >  	if (subopt_parse(ao_subdevice, subopts) != 0) {
> >  	  return 0;
> >  	}
> > -
> > -	ao_outputfilename =
> > -	      strdup((ao_pcm_waveheader)?"audiodump.wav":"audiodump.pcm");
> > +	if (!ao_outputfilename){
> > +	  ao_outputfilename =
> > +	    strdup(ao_pcm_waveheader?"audiodump.wav":"audiodump.pcm");
> > +	}
> 
> Cosmetics!

I don't think this is a problem, the goal of avoiding cosmetics is
maximizing diff readability.  This single hunk is trivial enough not to
be hurt by reindentation IMO.

Diego