[MPlayer-cvslog] CVS: main/DOCS/tech patches.txt,1.29,1.30
Diego Biurrun CVS
syncmail at mplayerhq.hu
Mon May 1 16:46:51 CEST 2006
CVS change done by Diego Biurrun CVS
Update of /cvsroot/mplayer/main/DOCS/tech
In directory mail:/var2/tmp/cvs-serv20631/DOCS/tech
Modified Files:
patches.txt
Log Message:
Expand a bit, clarification and grammar fix.
Index: patches.txt
===================================================================
RCS file: /cvsroot/mplayer/main/DOCS/tech/patches.txt,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- patches.txt 30 Apr 2006 20:36:13 -0000 1.29
+++ patches.txt 1 May 2006 14:46:49 -0000 1.30
@@ -18,10 +18,11 @@
2. Make unified diffs ('diff -Naur' or 'cvs diff -u'). Unified diffs can be
applied easily with 'patch'. This is much harder with other diff types.
+ Besides, unified diffs are more readable and thus easier to review.
3. Create the diff from the root of the MPlayer source tree, this makes the
- diff easier to apply as it saves the step of changing to the correct
- directory.
+ diff easier to apply as it saves the step of searching for and changing
+ to the correct directory.
4. Test the functionality of your patch. We'll *refuse* it if it breaks
something, even if it extends other features!
@@ -107,9 +108,9 @@
and translators will pick up changes more easily if they see a new message
that has to be translated.
-15. If you send a modified or updated version of you patch, always resend
- the complete patch. It is very time consuming and error prone to piece
- patches together that are distributed over several mails.
+15. If you send a modified or updated version of your patch, resend the
+ complete patch. It is very time-consuming and error-prone to piece
+ together patches that are distributed over several mails.
Please always resend patches as replies to the original mail to keep
the thread with the discussion together.
More information about the MPlayer-cvslog
mailing list