[MPlayer-cvslog] CVS: main/libmpdemux muxer_lavf.c,1.25,1.26

[Michael Niedermayer]

Hi

On Thu, Mar 23, 2006 at 09:47:43AM +0100, Nico Sabbi wrote:
> Reimar Döffinger wrote:
> >btw. there is still this rather funny code piece (lines 106 - 111):
> >muxer_priv_t *priv = muxer->priv;
> >[...]
> >if(!muxer || (type != MUXER_TYPE_VIDEO && type != MUXER_TYPE_AUDIO))
> >
> >Now, what would be the right way to "fix" this? May muxer be NULL here?
> >  
> 
> no
> 
> >Though there is no bog problem in leaving it as is, it's just a bit
> >weird *g*
> >
> >  
> 
> 
> Michael?

iam not sure, the check could be removed or be changed to an assert() as it
cannot happen or we could preventively leave it to protect against calling the
function with nonsense type i really dont know & care unless the code
becomes more complicated then it is now ...

[...]
-- 
Michael