[MPlayer-cvslog] CVS: main/TOOLS aconvert,1.2,1.3

[Jonas Jermann]

On Wed, Mar 22, 2006 at 12:33:07PM -0500, The Wanderer wrote:
> Jonas Jermann CVS wrote:
> 
> >CVS change done by Jonas Jermann CVS
> >
> >Update of /cvsroot/mplayer/main/TOOLS
> >In directory mail:/var2/tmp/cvs-serv32659
> >
> >Modified Files:
> >	aconvert 
> >Log Message:
> >use mencoder directly for mp3lame encoding instead of lavc
> 
> >-if [[ $3 == "" ]]; then
> >-    options="-oac lavc -lavcopts acodec=mp3:abitrate=192"
> >-else
> >-    options=$3
> >-fi
> >+options=${3:-"-oac mp3lame"}
> 
> This is not equivalent to the previous form, unless the bitrate for
> mp3lame defaults to 192. (Its default, if any, is not mentioned in the
> man page that I can see.)

Yes, I simply took the default settings, if the user wants his own
settings he can specify them in the options anyway. If the default
settings are bad, they should be changed and not this program imo.
Should have mentioned this in the commit message, sorry...
Besides mencoder's lame might differ in other aspects than only bitrate,
donno.. (?)


Best Regards
	Jonas Jermann