[MPlayer-cvslog] CVS: main subreader.c,1.147,1.148

[Rich Felker]

On Sun, Mar 19, 2006 at 07:17:35PM +0100, Jindrich Makovicka wrote:
> Rich Felker wrote:
> >BTW please do not cast the return value of malloc. Doing so is
> >incorrect and horrible style (it masks bugs).
> 
> Fortunately, not in newer gcc versions. You can also use -Wimplicit, if 
> missing includes scare you. It's a unnecessary C++ism, but IMO harmless.

What I said still applies. Do not do this!!!!

> >BTW2, 100l to whoever the idiot was who wrote malloc(foo*sizeof(char))
> >in the original code...
> 
> Gulp. Probably me, but as far as I remember, it was copy&paste from some 
> example program :)

....

Rich