[MPlayer-cvslog] CVS: main/libmpdemux muxer_lavf.c,1.23,1.24

[Nico Sabbi]

Michael Niedermayer wrote:

>Hi
>
>On Sun, Mar 12, 2006 at 07:06:48PM +0100, Nico Sabbi CVS wrote:
>  
>
>reverse this shit and the previous commit
>
>the correct fix for the "null check after use" issue coverity found is to
>remove the null check or put a assert(muxer) there, if you would have
>looked at the code instead randomly changeing it to hide as 
>many coverity warnings as quick as possible then you would have noticed
>that the theres a check for muxer being NULL before the 2 calls to
>lavf_new_stream()
>
>yeah fixing warnings that way is going to add more bugs then the code
>had to begin with
>
>[...]
>
>  
>


This patch reverses the muxer how it was in version 1.22 (the last one 
before my commits)
but keeps intact Rich's commit.
Ok to commit?

Sorry for having created problems.

    Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavf.diff
Type: text/x-patch
Size: 660 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20060312/dfe40aab/attachment.bin>