[MPlayer-cvslog] CVS: main Makefile,1.344,1.345

[Ivan Kalvachev]

2006/3/8, Jindrich Makovicka <makovick at kmlinux.fjfi.cvut.cz>:
> On 3/8/06, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> > Of course it did.
>
> Darn. Forgot the - prefix before $(MAKE).
>
> > libav* have never been parts of (PARTS).
>
> libavcodec is in PARTS since PARTS has been introduced, similar for the others.
>
> http://www1.mplayerhq.hu/cgi-bin/cvsweb.cgi/main/Makefile.diff?r1=1.57&r2=1.58
>
> > They are in AV_LIBS (config.mak) , that gets in CODECS_LIBS, that gets
> > in COMMON_LIBS, then LIBS_MPLAYER ....
>
> nevertheless, I still would like to keep these changes, as adding the
> - should finally fix this matter. And with the patch reverted, make
> depend doesn't work in libpostproc.

The point is that your patch is ugly hack.
The right fix is to make libav* part of PARTS when it is static and
leave it in CODECS_LIBS when it is dynamic (this includes handling of
mixed cases).

So revert and make the things properly.